[Webkit-unassigned] [Bug 91196] Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91196





--- Comment #5 from Vivek Galatage <vivekgalatage at gmail.com>  2012-07-13 11:03:20 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > I was more thinking that:
> > 
> > class InspectorClientQt : public InspectorClient,
> >                         : public InspectorFrontendChannel {
> > }
> > 
> > and would pass this into the connectFrontend in order to minimize the amount of changes.
> 
> Thank you Pavel. I was thinking of the same earlier to minimize the changes. But again I thought, these approaches might separate the classes logically as well. Hence proposed these solutions.
> 
> Sure, I will go ahead with these changes as per your proposal.

We need to also introduce method like frontendChannel() in InspectorClient so as to refer this from InspectorController:

class InspectorClient {
public:
    virtual InspectorFrontendChannel* frontendChannel() const = 0;
}

The method would typically return "this" from the implementation(e.g. InspectorClientQt)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.