[Webkit-unassigned] [Bug 91089] [NRWT] runs platform specific tests that it shouldn't when invoked on a directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91089


Balazs Kelemen <kbalazs at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org,
                   |                            |jesus at webkit.org,
                   |                            |tony at chromium.org




--- Comment #4 from Balazs Kelemen <kbalazs at webkit.org>  2012-07-13 04:18:59 PST ---
I see, I agree it's actually not a bug. It seems the right behavior of  --force to run these tests. However, when using --force to check what can be removed from skip list, this behavior is a bit uncomfortable. I don't think ports want to run tests from LayoutTests/platform other than the ones that belongs to them. Yesterday I made this tiny change locally:

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py
index fbf0b93..3d28dbc 100755
--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -506,7 +506,7 @@ class Port(object):
             expanded_paths.append(path)
             if self.test_isdir(path) and not path.startswith('platform'):
                 for platform_dir in all_platform_dirs:
-                    if fs.isdir(fs.join(platform_dir, path)):
+                    if fs.isdir(fs.join(platform_dir, path)) and platform_dir in self.baseline_search_path():
                         expanded_paths.append(self.relative_test_filename(fs.join(platform_dir, path)))

         return expanded_paths


With this change I believe we are still be able to run other platform's tests with --additional-platform-directory. So, the question is whether it is worth to mess up the semantic of --force a bit in favor of easier skip list maintenance. I'm curious about other's opinion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.