[Webkit-unassigned] [Bug 91089] [NRWT] runs platform specific tests that it shouldn't when invoked on a directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 20:06:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91089





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2012-07-12 20:06:20 PST ---
Ah, I see what's going on .

The way things are implemented in NRWT, we find *all* of the tests in the tree, and then add SKIP expectations for the tests we don't want to run (as returned by Port.skipped_layout_tests). That means that there is a SKIP expectation for platform/chromium.

However, you're running with --force, which says to run all tests, even if they're skipped :).

I'm not sure if I consider this a bug so much as an unfortunate interaction of the three features (finding platform-specific versions of tests for a generic directory, implicitly skipping platforms other than your own, and --force).

I think you can work around this by -i/--ignore-tests platform/chromium, but --force might actually trump everything, and I'm not sure that that's bad.

Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list