[Webkit-unassigned] [Bug 90758] Refactoring metadata of BitmapImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90758





--- Comment #10 from Zoltan Horvath <zoltan at webkit.org>  2012-07-11 04:48:42 PST ---
(In reply to comment #9)
> Yes, we can use ImageFrameData as a member instead. But then member references become too verbose. For example, m_frames[i].m_isComplete becomes m_frames[i].m_imageFrameData.m_isComplete.

We can avoid the verbosity by adding member access functions to the class, let's listen other's opinions.

> Also because these two classes are used for different purposes, we didn't want to embed ImageFrameData in Bitmap's FrameData.
> 
> So we chose to duplicate members here.

Oh, I see. Hmm we have 3 slightly different instances of this member group: FrameData, ImageFrameData, ParallelFrameData. Did you consider to merge them somehow? Or would it increase the complexity too much and mix things that attend to different purposes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.