[Webkit-unassigned] [Bug 90758] Refactoring metadata of BitmapImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90758





--- Comment #9 from Kwang Yul Seo <skyul at company100.net>  2012-07-11 03:52:44 PST ---
(In reply to comment #7)
> (From update of attachment 151620 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151620&action=review
> 
> > Source/WebCore/platform/graphics/BitmapImage.h:108
> >      NativeImagePtr m_frame;
> 
> Doesn't make sense to use the a ImageFrameData object here as a member instead?

Yes, we can use ImageFrameData as a member instead. But then member references become too verbose. For example, m_frames[i].m_isComplete becomes m_frames[i].m_imageFrameData.m_isComplete.

Also because these two classes are used for different purposes, we didn't want to embed ImageFrameData in Bitmap's FrameData.

So we chose to duplicate members here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.