[Webkit-unassigned] [Bug 90911] [BlackBerry] Implement Date/Time picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90911





--- Comment #3 from Crystal Zhang <haizhang at rim.com>  2012-07-10 15:21:02 PST ---
(In reply to comment #2)
> (From update of attachment 151535 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151535&action=review
> 
> Can be improved some more.
> 
> > Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:44
> > +    void generateHTML(BlackBerry::Platform::BlackBerryInputType, const BlackBerry::WebKit::WebString& value, const BlackBerry::WebKit::WebString& min, const BlackBerry::WebKit::WebString& max, double step);
> 
> You can probably make some stuff more private, this is probably internal.
The parameters passed from ctor that needed have been made private, others are just for generating HTML.
> 
> > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:504
> > +        WTF::String value = element->value();
> 
> WTF:: prefix can go in this file.
ok.
> 
> > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:509
> > +        DatePickerClient* client = new DatePickerClient(type, value, min, max, step,  m_webPage, element);
> 
> Who deletes client?
DatePickerClient will be passed to PagePopupBlackBerry as an OwnPtr, and will be deleted automatically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.