[Webkit-unassigned] [Bug 90911] [BlackBerry] Implement Date/Time picker
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 10 15:16:26 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90911
Rob Buis <rwlbuis at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151535|review? |review-
Flag| |
--- Comment #2 from Rob Buis <rwlbuis at gmail.com> 2012-07-10 15:16:26 PST ---
(From update of attachment 151535)
View in context: https://bugs.webkit.org/attachment.cgi?id=151535&action=review
Can be improved some more.
> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:44
> + void generateHTML(BlackBerry::Platform::BlackBerryInputType, const BlackBerry::WebKit::WebString& value, const BlackBerry::WebKit::WebString& min, const BlackBerry::WebKit::WebString& max, double step);
You can probably make some stuff more private, this is probably internal.
> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:504
> + WTF::String value = element->value();
WTF:: prefix can go in this file.
> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:509
> + DatePickerClient* client = new DatePickerClient(type, value, min, max, step, m_webPage, element);
Who deletes client?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list