[Webkit-unassigned] [Bug 90721] Don't destroy the decoded data of an image if WebKit is about to render the image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90721





--- Comment #21 from Kwang Yul Seo <skyul at company100.net>  2012-07-10 03:23:40 PST ---
(In reply to comment #20)
> (From update of attachment 151397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151397&action=review
> 
> Nice patch.
> 
> > Source/WebCore/loader/cache/CachedImage.h:133
> > -    virtual bool willRenderImage(CachedImage*) { return false; }
> > +    virtual bool willRenderImage() const { return false; }
> 
> I would keep the CachedImage* argument, even if currently unused, for consistency with other cache client calls. It also makes it clear that this is a cache client function (willRenderImage() on RenderObject could be anything otherwise) and could be useful for asserts.

Then CachedImage::likelyToBeUsedSoon() can't be const because it internally calls client->willRenderImage(this). 'this' pointer here is const CachedImage*, not CachedImage*.

I think it is better to drop const from CachedImage::likelyToBeUsedSoon() because another query method CachedImage::shouldPauseAnimation() is not const anyway.

If it is okay, I will land the patch for Dongsung after dropping const from CachedImage::likelyToBeUsedSoon().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.