[Webkit-unassigned] [Bug 90721] Don't destroy the decoded data of an image if WebKit is about to render the image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90721


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151397|review?                     |review+
               Flag|                            |




--- Comment #20 from Antti Koivisto <koivisto at iki.fi>  2012-07-10 03:03:18 PST ---
(From update of attachment 151397)
View in context: https://bugs.webkit.org/attachment.cgi?id=151397&action=review

Nice patch.

> Source/WebCore/loader/cache/CachedImage.h:133
> -    virtual bool willRenderImage(CachedImage*) { return false; }
> +    virtual bool willRenderImage() const { return false; }

I would keep the CachedImage* argument, even if currently unused, for consistency with other cache client calls. It also makes it clear that this is a cache client function (willRenderImage() on RenderObject could be anything otherwise) and could be useful for asserts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.