[Webkit-unassigned] [Bug 90622] blockfreeing thread doesn't need to wake up every 1 second

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90622


Yong Li <yoli at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #2 from Yong Li <yoli at rim.com>  2012-07-05 11:06:26 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > void BlockAllocator::blockFreeingThreadMain()
> > {
> >     while (!m_blockFreeingThreadShouldQuit) {
> >         // Generally wait for one second before scavenging free blocks. This
> >         // may return early, particularly when we're being asked to quit.
> >         waitForRelativeTime(1.0);
> >         if (m_blockFreeingThreadShouldQuit)
> >             break;
> > 
> > 
> > Actually a conditional signal is being used. So the 1 second timeout doesn't seem
> > necessary.
> 
> Where is this imaginary conditional signal?
> 
> The block freeing thread does not get signaled when there are free blocks.
> 

Hm... I thought m_freeBlockCondition was for that purpose. Sorry for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.