[Webkit-unassigned] [Bug 90622] blockfreeing thread doesn't need to wake up every 1 second

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 10:59:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90622





--- Comment #1 from Filip Pizlo <fpizlo at apple.com>  2012-07-05 10:59:22 PST ---
(In reply to comment #0)
> void BlockAllocator::blockFreeingThreadMain()
> {
>     while (!m_blockFreeingThreadShouldQuit) {
>         // Generally wait for one second before scavenging free blocks. This
>         // may return early, particularly when we're being asked to quit.
>         waitForRelativeTime(1.0);
>         if (m_blockFreeingThreadShouldQuit)
>             break;
> 
> 
> Actually a conditional signal is being used. So the 1 second timeout doesn't seem
> necessary.

Where is this imaginary conditional signal?

The block freeing thread does not get signaled when there are free blocks.

> 
> Can we change it to infinite?

No.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list