[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76035





--- Comment #68 from Pablo Flouret <pablof at motorola.com>  2012-01-31 16:23:55 PST ---
Ok, let me make a new bug for the popstate stuff to make things a bit easier.

(In reply to comment #67)
> (From update of attachment 124811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124811&action=review
> 
> r- due to removed PopStateEvent constructor.
> 
> It is good to show the whole image of your intended change, but it might be better to split the big patch into sub-patches for review, so that each sub-patch is small enough to confirm that it is correct.
> 
> > Source/WebCore/dom/PopStateEvent.idl:31
> > +        readonly attribute [CustomGetter] DOMObject state;
> 
> Why did you remove [ConstructorTemplate=Event] and [InitializedByConstructor]? Then I am afraid that "new PopStateEvent()" wouldn't work.

I might've been too eager in removing stuff wrt ConstructorTemplate, i'll put it back in. Now that the state is taken directly from the history object how would InitializedByConstructor work in this case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.