[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 16:06:02 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76035


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124811|review?                     |review-
               Flag|                            |




--- Comment #67 from Kentaro Hara <haraken at chromium.org>  2012-01-31 16:06:00 PST ---
(From update of attachment 124811)
View in context: https://bugs.webkit.org/attachment.cgi?id=124811&action=review

r- due to removed PopStateEvent constructor.

It is good to show the whole image of your intended change, but it might be better to split the big patch into sub-patches for review, so that each sub-patch is small enough to confirm that it is correct.

> Source/WebCore/dom/PopStateEvent.idl:31
> +        readonly attribute [CustomGetter] DOMObject state;

Why did you remove [ConstructorTemplate=Event] and [InitializedByConstructor]? Then I am afraid that "new PopStateEvent()" wouldn't work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list