[Webkit-unassigned] [Bug 76801] Listboxes incorrectly display contents when cleared and then re-populated
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 30 13:35:40 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76801
--- Comment #22 from Joe Thomas <joethomas at motorola.com> 2012-01-30 13:35:40 PST ---
(In reply to comment #21)
> (From update of attachment 124335 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124335&action=review
>
Thanks for the review.
> You need pixel results for the new tests (run-webkit-tests --pixel). r- for lack of pixel results.
>
I added a reftest for this defect as per Alexey's suggestion in comment #4.
I am new to webkit. How do I get pixel results for this? I tried running run-webkit-tests --pixel, but it did not generate any pixel results. Could you please point me to a similar defect which I can refer to?
> > Source/WebCore/rendering/RenderListBox.cpp:258
> > + ScrollableArea::scrollToYOffsetWithoutAnimation(0);
>
> Does the call to scrollToYOffsetWithoutAnimation() have to be prefixed with the class name? Are you specifically calling the base class implementation?
>
It is not needed. scrollToYOffsetWithoutAnimation has got implementation only in the base class. I added it because I saw similar usage in RenderListBox. I will remove this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list