[Webkit-unassigned] [Bug 76801] Listboxes incorrectly display contents when cleared and then re-populated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76801


Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124335|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #21 from Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com>  2012-01-30 12:38:33 PST ---
(From update of attachment 124335)
View in context: https://bugs.webkit.org/attachment.cgi?id=124335&action=review

You need pixel results for the new tests (run-webkit-tests --pixel). r- for lack of pixel results.

> Source/WebCore/rendering/RenderListBox.cpp:258
> +           ScrollableArea::scrollToYOffsetWithoutAnimation(0);

Does the call to scrollToYOffsetWithoutAnimation() have to be prefixed with the class name? Are you specifically calling the base class implementation?

> LayoutTests/fast/forms/listbox-clear-restore-expected.html:10
> +    var myList = document.getElementById("myList"),
> +        item,
> +        ii;

We don't declare variables like this normally.

> LayoutTests/fast/forms/listbox-clear-restore-expected.html:12
> +    for (ii = 0; ii < 100; ii++) {

ii could be a loop variable for (var ii ...

> LayoutTests/fast/forms/listbox-clear-restore.html:12
> +    var myList = document.getElementById("myList"),
> +        item,
> +        ii;
> +
> +    for (ii = 0; ii < 100; ii++) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.