[Webkit-unassigned] [Bug 77319] [EFL] Set content hint information for ewk_view_single.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77319





--- Comment #15 from KwangHyuk <hyuki.kim at samsung.com>  2012-01-30 07:22:27 PST ---
(In reply to comment #10)
> (From update of attachment 124515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124515&action=review
> 
> > Source/WebKit/efl/ChangeLog:28
> > +2012-01-29  KwangHyuk Kim  <hyuki.kim at samsung.com>
> > +
> > +        [EFL] Set content hint information for ewk_view_single.
> > +        https://bugs.webkit.org/show_bug.cgi?id=77319
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        The content hint information corresponding to opengl_x11 engine is set
> > +        for the image object which ewk_view_single owns when evas is based on
> > +        opengl_x11 engine.
> > +
> > +        * ewk/ewk_view_single.cpp:
> > +        (_ewk_view_single_smart_backing_store_add):
> > +
> 
> Duplicate ChangeLog.

Thx,fixed. :)

> 
> >>> Source/WebKit/efl/ewk/ewk_view_single.cpp:63
> >>> +    const WTF::String engine(ecore_evas_engine_name_get(ecoreEvas));
> >>> +    if (engine == "opengl_x11")
> >> 
> >> If engine name may become upper case, why don't you compare both via equalIgnoringCase() ?
> > 
> > Good point.
> > In fact I referred the efl code in /ecore_evas/ecore_evas.c.
> > And then I could know that efl is just using lower case letters. :)
> > 
> > static const struct ecore_evas_engine _engines[] = {
> >   /* unix */
> > #ifdef BUILD_ECORE_EVAS_SOFTWARE_X11
> >   {"software_x11", _ecore_evas_constructor_software_x11},
> > #endif
> > #ifdef BUILD_ECORE_EVAS_OPENGL_X11
> >   {"opengl_x11", _ecore_evas_constructor_opengl_x11},
> > #endif
> > #ifdef BUILD_ECORE_EVAS_SOFTWARE_8_X11
> >   {"software_8_x11", _ecore_evas_constructor_software_8_x11},
> > #endif
> > #ifdef BUILD_ECORE_EVAS_SOFTWARE_16_X11
> >   {"software_16_x11", _ecore_evas_constructor_software_16_x11},
> > #endif
> > #ifdef BUILD_ECORE_EVAS_DIRECTFB
> >   {"directfb", _ecore_evas_constructor_directfb},
> > #endif
> > #ifdef BUILD_ECORE_EVAS_FB
> >   {"fb", _ecore_evas_constructor_fb},
> > #endif
> 
> I don't see the need for the const char* -> WTF::String conversions at all.
> 
> const Ecore_Evas* ecoreEvas = ecore_evas_ecore_evas_get(smartData->base.evas);
> const char* engine = ecore_evas_engine_name_get(ecoreEvas);
> if (!strncmp(engine, "opengl_x11", strlen("opengl_x11")))
>     evas_object_image_content_hint_set(...);

I agree with you. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.