[Webkit-unassigned] [Bug 77086] [GStreamer] 0.11 webkitwebsrc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77086





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-01-30 07:17:41 PST ---
(From update of attachment 124090)
View in context: https://bugs.webkit.org/attachment.cgi?id=124090&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:127
> +static void webKitWebSrcNeedDataCb(GstAppSrc*, guint, gpointer);
> +static void webKitWebSrcEnoughDataCb(GstAppSrc*, gpointer);
> +static gboolean webKitWebSrcSeekDataCb(GstAppSrc*, guint64, gpointer);
>  
> -static void webKitWebSrcStop(WebKitWebSrc* src, bool seeking);
> -static gboolean webKitWebSrcSetUri(GstURIHandler*, const gchar*);
> -static const gchar* webKitWebSrcGetUri(GstURIHandler*);
> +static void webKitWebSrcStop(WebKitWebSrc*, bool);

You should actually continue include the variable name here for generic types like guint64 and gpointer.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:556
> +const gchar * const * webKitWebSrcGetProtocols(GType)

The spacing of the asterisks is off here.

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:558
>> +    static gchar* protocols[] = {(gchar*) "http", (gchar*) "https", 0 };
> 
> static_cast<>, I'd say let's not use the gchar defines unless it's necessary =)

I think you can avoid the casts entirely if you make this something like

static const char* protocols[] = {"http", "https", 0};

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:568
> +    WebKitWebSrc* src = WEBKIT_WEB_SRC(handler);
> +    WebKitWebSrcPrivate* priv = src->priv;
> +
> +    return g_strdup(priv->uri);

Just make this one line: return g_strdrup(WEBKIT_WEB_SRC(handler)->priv->uri));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.