[Webkit-unassigned] [Bug 77086] [GStreamer] 0.11 webkitwebsrc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77086


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124090|review?                     |review+
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2012-01-30 05:28:59 PST ---
(From update of attachment 124090)
View in context: https://bugs.webkit.org/attachment.cgi?id=124090&action=review

Thanks Sebastian for the review! A couple nits + the error fix and this is good to land.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:509
>      case GST_QUERY_DURATION:
> -    {
> -        GstFormat format;
> +        {
> +            GstFormat format;

It's usual for these braces to be in the same line as the case statement, and close on the same column as the c in case.

case BLA: {
    codegoeshere;
}

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:558
> +    static gchar* protocols[] = {(gchar*) "http", (gchar*) "https", 0 };

static_cast<>, I'd say let's not use the gchar defines unless it's necessary =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.