[Webkit-unassigned] [Bug 77319] [EFL] Set content hint information for ewk_view_single.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77319





--- Comment #9 from KwangHyuk <hyuki.kim at samsung.com>  2012-01-30 02:54:00 PST ---
(In reply to comment #8)
> (From update of attachment 124515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124515&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view_single.cpp:63
> > +    if (engine == "opengl_x11")
> 
> If engine name may become upper case, why don't you compare both via equalIgnoringCase() ?

Good point.
In fact I referred the efl code in /ecore_evas/ecore_evas.c.
And then I could know that efl is just using lower case letters. :)

static const struct ecore_evas_engine _engines[] = {
  /* unix */
#ifdef BUILD_ECORE_EVAS_SOFTWARE_X11
  {"software_x11", _ecore_evas_constructor_software_x11},
#endif
#ifdef BUILD_ECORE_EVAS_OPENGL_X11
  {"opengl_x11", _ecore_evas_constructor_opengl_x11},
#endif
#ifdef BUILD_ECORE_EVAS_SOFTWARE_8_X11
  {"software_8_x11", _ecore_evas_constructor_software_8_x11},
#endif
#ifdef BUILD_ECORE_EVAS_SOFTWARE_16_X11
  {"software_16_x11", _ecore_evas_constructor_software_16_x11},
#endif
#ifdef BUILD_ECORE_EVAS_DIRECTFB
  {"directfb", _ecore_evas_constructor_directfb},
#endif
#ifdef BUILD_ECORE_EVAS_FB
  {"fb", _ecore_evas_constructor_fb},
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.