[Webkit-unassigned] [Bug 77148] [Qt][Texmap] Refactor TextureMapper backing stores.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77148





--- Comment #4 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2012-01-27 07:20:47 PST ---
(From update of attachment 124186)
View in context: https://bugs.webkit.org/attachment.cgi?id=124186&action=review

Went through it and it looks good, just got two nitpicks.

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:589
> +static void swizzleRgb(uint32_t* data, const IntSize& size)

It's called swizzleRGB with capitals in ShareableBitmap, maybe it's worth to keep the names consistent.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:123
> +void swizzleRgb(Image*);

It's defined static and used only in TextureMapperGL.cpp.
Does this belong in TextureMapper.h?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.