[Webkit-unassigned] [Bug 77148] [Qt][Texmap] Refactor TextureMapper backing stores.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 15:57:45 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77148





--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-01-26 15:57:45 PST ---
(In reply to comment #2)
> (From update of attachment 124186 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124186&action=review
> 
> It is pretty amazing that you are able to remove so much code
> 
> > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:615
> > +        swizzleRgb(reinterpret_cast<uint32_t*>(qtImage.bits()), qtImage.size());
> 
> werent you going to rename this method just jocelyn asked you to?

He asked that I add a comment in WebGraphicsLayer what I'm swizzling to/from. Here it should be inferred from the code but I can add a comment as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list