[Webkit-unassigned] [Bug 76110] Event Queue for HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76110





--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2012-01-20 10:48:34 PST ---
(From update of attachment 123272)
View in context: https://bugs.webkit.org/attachment.cgi?id=123272&action=review

> Source/WebCore/html/MediaEventQueue.h:34
> +class MediaEventQueue : public EventQueue {
> +
> +public:
> +    MediaEventQueue();
> +    virtual ~MediaEventQueue();
> +
> +    // EventQueue
> +    virtual bool enqueueEvent(PassRefPtr<Event>) OVERRIDE;
> +    virtual bool cancelEvent(Event*) OVERRIDE;
> +    virtual void close() OVERRIDE;
> +
> +    void cancelAllEvents();
> +    bool hasPendingEvents() const;
> +
> +private:
> +    void timerFired(Timer<MediaEventQueue>*);
> +
> +    Vector<RefPtr<Event> > m_pendingEvents;
> +    Timer<MediaEventQueue> m_timer;
> +
> +    bool m_isClosed;

Why is this class called "MediaEventQueue"? We may end with a class that is specific to the media element at some point, but at this point it is just a generic event queue that could be used by other classes. 

I think this should a more generic name, GenericEventQueue or SimpleEventQueue perhaps, and it should be in WebCore/dom along with the abstract base class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.