[Webkit-unassigned] [Bug 76110] Event Queue for HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76110


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123272|                            |review-
               Flag|                            |




--- Comment #5 from Eric Carlson <eric.carlson at apple.com>  2012-01-20 10:27:36 PST ---
(From update of attachment 123272)
View in context: https://bugs.webkit.org/attachment.cgi?id=123272&action=review

Marking r- only because it fails to compile on ports that don't define VIDEO_TRACK.

> Source/WebCore/html/MediaEventQueue.cpp:8
> +

Nit: This extra blank line is unnecessary.

> Source/WebCore/html/MediaEventQueue.cpp:70
> +    if (m_timer.isActive())

Nit: MediaEventQueue::close calls stop() without checking to see if the timer is active, to be consistent you should one or the other throughout the file. stop() is cheap so I would probably just call it but I don't have a strong preference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.