[Webkit-unassigned] [Bug 76239] DrawingBuffer is not cleared correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76239





--- Comment #13 from Kenneth Russell <kbr at google.com>  2012-01-18 18:22:55 PST ---
(In reply to comment #12)
> > (In reply to comment #10)
> > > This patch appears to have broken fast/canvas/webgl/drawingbuffer-test.html:
> > > 
> > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcanvas%2Fwebgl%2Fdrawingbuffer-test.html
> > 
> > yongsheng, did you run the layout tests?
> > 
> > Filed https://bugs.webkit.org/show_bug.cgi?id=76562 to track this regression.
> Sorry, I should notify that the fix for this might expose the failure for these kind of cases which don't occur before. This kind of failure is somewhat random. Actually both 2 cases are almost the same.
> The reason could be see from here: http://code.google.com/p/chromium/issues/detail?id=104740#c5
> This case is also to test DrawingBuffer. And the root cause of this case is the same. The failure is because of the V8 GC issue. 
> 
> There are 2 ways:
> 1) revert the patch and commit it together with the patch for #76225(release GL context).
> 2) Or don't revert it and it will get fixed with the patch for #76225.
> what's your opinion? 
> 
> I should raise it clearly. It's my fault. Sorry about that.

I don't see how fixing Bug 76225 will affect the execution of fast/canvas/webgl/drawingbuffer-test.html. There is no JavaScript-level garbage collection involved when the canvas's width and height are changed. Bug 76255 will only release WebGL resources more eagerly when the page is unloaded.

Is this analysis correct? If it is, then this patch should definitely be rolled out and rethought.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.