[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76035





--- Comment #38 from Kentaro Hara <haraken at chromium.org>  2012-01-17 20:45:08 PST ---
(From update of attachment 122857)
View in context: https://bugs.webkit.org/attachment.cgi?id=122857&action=review

r+ for the CodeGenerator change.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2037
> +                                    my $callWithArg = GenerateAttributeCallWith($callWith, \@implContent, 1);
> +                                    unshift(@arguments, $callWithArg);

Nit: You can just write unshift(@arguments, GenerateAttributeCallWith($callWith, \@implContent, 1));

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2396
> +    my $returnVoid = shift || 0;

Nit: || 0 is not necessary

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:902
> +    my $callWith = $attribute->signature->extendedAttributes->{"CallWith"} || "";

Nit: || "" is not necessary.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:909
> +            my $callWithArg = GenerateAttributeCallWith($callWith, \@implContentDecls);
> +            push(@arguments, $callWithArg);

Nit: You can just write push(@arguments, GenerateAttributeCallWith($callWith, \@implContentDecls));

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1145
> +    my $callWith = $attribute->signature->extendedAttributes->{"CallWith"} || "";

Nit: || "" is not necessary.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1174
> +                my $callWithArg = GenerateAttributeCallWith($callWith, \@implContentDecls, 1);
> +                push(@arguments, $callWithArg);

Nit: You can just write push(@arguments, GenerateAttributeCallWith($callWith, \@implContentDecls, 1));

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1488
> +    my $returnVoid = shift || 0;

Nit: || 0 is not necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.