[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 21:02:16 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76035





--- Comment #39 from Pablo Flouret <pablof at motorola.com>  2012-01-17 21:02:15 PST ---
(In reply to comment #38)
> (From update of attachment 122857 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122857&action=review
> 
> r+ for the CodeGenerator change.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:902
> > +    my $callWith = $attribute->signature->extendedAttributes->{"CallWith"} || "";
> 
> Nit: || "" is not necessary.

I get a whole bunch of warnings like "Use of uninitialized value $callWith in string eq at CodeGeneratorV8.pm" if i don't do that one, maybe i'm doing something wrong? (i seem to recall the same thing happening for the other ones, but they don't appear anymore, weird).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list