[Webkit-unassigned] [Bug 76069] [GTK] ATK text-caret-moved and text-selection-changed events not being emitted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76069


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122203|0                           |1
        is obsolete|                            |
 Attachment #122637|                            |review?
               Flag|                            |




--- Comment #6 from Mario Sanchez Prada <msanchez at igalia.com>  2012-01-16 07:52:18 PST ---
Created an attachment (id=122637)
 --> (https://bugs.webkit.org/attachment.cgi?id=122637&action=review)
Patch proposal

(In reply to comment #5)
> It seems this is not properly fixed yet. The patch caused trouble in the GTK 64 bit Debug bot, so I had to roll it out: https://bugs.webkit.org/show_bug.cgi?id=76267

The attached new patch uses positionBeforeNode instead of firstPositionInNode (which should be equivalent in this case, while not making that ASSERT fail) and also takes special care on the fact that the reference object passed to objectFocusedAndCaretOffsetUnignored should either be the same object being actually considered (and returned) or an ascendant, but never a descendant of such actual object.

I tested it in a debug 64bit build and seems to pass both the unit and layout tests. That must mean something

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.