[Webkit-unassigned] [Bug 64468] WIN: DumpRenderTree hangs under NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 5 08:39:43 PST 2012


--- Comment #10 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-05 08:39:43 PST ---
(In reply to comment #5)
> Note that abspath_for_test isn't sufficient on Windows because it will produce a Cygwin-style path.
> The bare-minimum required change is here:
> http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py?rev=90826#L465
> Changing this:
> command = uri[7:] if uri.startswith("file:///") else uri
> to this:
> command = cygpath(urllib.unquote(uri[7:])) if uri.startswith("file:///") else uri
> This is a bit icky, of course, since we're converting to a URL then back to a path (but the code already does this). I think the urllib.unquote call is actually the right thing to do on all platforms if we keep this test name -> URL -> file path approach. Only the cygpath() call is Windows-specific.

It seems that uri now contains a Windows-style file: URL, not a Cygwin-style file: URL. Not sure when that changed. Anyway, now the minimum change is:

command = urllib.unquote(uri[8:]).replace('/', '\\') if uri.startswith("file:///") else uri

Gotta come up with some better solution that doesn't break Mac etc. of course :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list