[Webkit-unassigned] [Bug 64468] WIN: DumpRenderTree hangs under NRWT
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 08:25:10 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=64468
--- Comment #9 from Adam Roben (:aroben) <aroben at apple.com> 2012-01-05 08:25:09 PST ---
(In reply to comment #7)
> There's no reason to go through the URL if you don't need to. You could just as easily change command_From_driver_input() to something like:
>
> if driver_input.test_name.startswith('http/'):
> command = self.test_to_uri(driver_input.test_name)
> else:
> command = cygpath(self.abspath_for_test(driver_input.test_name)
Unfortunately, test_to_uri contains some tricky logic about whether to use an http:/https: URL or a file: URL. I don't think we want to duplicate that logic in command_from_driver_input. Maybe we can share the logic, or maybe we can make the roundtrip through test_to_uri work.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list