[Webkit-unassigned] [Bug 75433] [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75433





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-02 08:33:53 PST ---
(In reply to comment #5)
> > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:623
> > > >      if (!m_pendingAPIRequestURL.isNull())
> > > >          return m_pendingAPIRequestURL;
> > > >  
> > > > -    // FIXME: What do we do in the case of the unreachable URL?
> > > > +    if (!m_mainFrame->unreachableURL().isEmpty())
> > > > +        return m_mainFrame->unreachableURL();
> > > >  
> > > >      switch (m_mainFrame->loadState()) {
> > > 
> > > Was this added accidentally?
> > 
> > No, when using loadAlternateHTML the active uri is actually the unreachableURL, since it's the uri you want to use for the new page contents. Othrewise this returns about:blank.
> 
> It seems like this should be in another bug, since it isn't strictly renaming the method. Another reason I say this is that I'm confident enough to review the rename, but not familiar enough with this cross-platform code to review it. I'm not sure Anders and Sam are interested in reviewing the API change either. It seems like it should be split off.

You are right, I added it because it breaks the unit test, but I'll file a new bug report for it blocking this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.