[Webkit-unassigned] [Bug 75433] [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 2 08:30:20 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=75433
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mrobinson at webkit.org
--- Comment #5 from Martin Robinson <mrobinson at webkit.org> 2012-01-02 08:30:20 PST ---
> > > Source/WebKit2/UIProcess/WebPageProxy.cpp:623
> > > if (!m_pendingAPIRequestURL.isNull())
> > > return m_pendingAPIRequestURL;
> > >
> > > - // FIXME: What do we do in the case of the unreachable URL?
> > > + if (!m_mainFrame->unreachableURL().isEmpty())
> > > + return m_mainFrame->unreachableURL();
> > >
> > > switch (m_mainFrame->loadState()) {
> >
> > Was this added accidentally?
>
> No, when using loadAlternateHTML the active uri is actually the unreachableURL, since it's the uri you want to use for the new page contents. Othrewise this returns about:blank.
It seems like this should be in another bug, since it isn't strictly renaming the method. Another reason I say this is that I'm confident enough to review the rename, but not familiar enough with this cross-platform code to review it. I'm not sure Anders and Sam are interested in reviewing the API change either. It seems like it should be split off.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list