[Webkit-unassigned] [Bug 75433] [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75433





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-02 08:25:17 PST ---
(In reply to comment #3)
> (From update of attachment 120872 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120872&action=review
> 
> Looks fine to me, but I'm holding off on r+ until I understand the change in Source/WebKit2/UIProcess/WebPageProxy.cpp.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:685
> > + * Replace the content of @web_view with @content using @content_uri as page URI.
> > + * This allows clients to display page-loading errors in the #WebKitWebView itself.
> > + * This is typically called from
> > + * #WebKitWebLoaderClient::provisional-load-failed or #WebKitWebLoaderClient::load-failed
> > + * signals.
> > + * The URI passed in @base_uri has to be an absolute URI.
> 
> I think it could be useful here to explicitly mention that the difference between this and load_content is that this does not trigger load signals.

Yes, I plan to do that in a new patch as soon as new loader client patch lands, because in this moment this method do actually trigger load signals. So, once we have the new loader client, I'll fix it to not trigger load signals when replacing content and I'll comment it here too.

> > Source/WebKit2/UIProcess/WebPageProxy.cpp:623
> >      if (!m_pendingAPIRequestURL.isNull())
> >          return m_pendingAPIRequestURL;
> >  
> > -    // FIXME: What do we do in the case of the unreachable URL?
> > +    if (!m_mainFrame->unreachableURL().isEmpty())
> > +        return m_mainFrame->unreachableURL();
> >  
> >      switch (m_mainFrame->loadState()) {
> 
> Was this added accidentally?

No, when using loadAlternateHTML the active uri is actually the unreachableURL, since it's the uri you want to use for the new page contents. Othrewise this returns about:blank.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.