[Webkit-unassigned] [Bug 75435] [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75435





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-02 08:20:37 PST ---
(In reply to comment #5)
> (From update of attachment 120879 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120879&action=review
> 
> Nice.
> 
> > Source/WebCore/platform/gtk/GtkVersioning.c:355
> > +    int result = XGetWindowProperty(display, rootWindow, workArea, 0, 4 * 32 /* Mas len */, False, AnyPropertyType,
> 
> Mas len -> max length?

oops! :-P

> >> Source/WebCore/platform/gtk/GtkVersioning.h:121
> >> +void gdk_screen_get_monitor_workarea(GdkScreen *screen, int monitor, GdkRectangle *area);
> > 
> > The parameter name "screen" adds no information, so it should be removed.  [readability/parameter_name] [5]
> 
> Go ahead and fix this one, I'd say.

I didn't fix it because all other prototypes in that header don't follow that rule, and I thought it was because that's C and not C++.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.