[Webkit-unassigned] [Bug 75435] [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()

Mon Jan 2 08:17:41 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=75435

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120879|review?                     |review+
               Flag|                            |

--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-01-02 08:17:41 PST ---
(From update of attachment 120879)
View in context: https://bugs.webkit.org/attachment.cgi?id=120879&action=review

Nice.

> Source/WebCore/platform/gtk/GtkVersioning.c:355
> +    int result = XGetWindowProperty(display, rootWindow, workArea, 0, 4 * 32 /* Mas len */, False, AnyPropertyType,

Mas len -> max length?

>> Source/WebCore/platform/gtk/GtkVersioning.h:121
>> +void gdk_screen_get_monitor_workarea(GdkScreen *screen, int monitor, GdkRectangle *area);
> 
> The parameter name "screen" adds no information, so it should be removed.  [readability/parameter_name] [5]

Go ahead and fix this one, I'd say.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.