[Webkit-unassigned] [Bug 59961] Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 21:04:28 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=59961





--- Comment #15 from Pablo Flouret <pablof at motorola.com>  2012-02-29 21:04:28 PST ---
(In reply to comment #14)
> (From update of attachment 129621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129621&action=review
> 
> > Source/WebCore/editing/Editor.cpp:3028
> > +PassRefPtr<HTMLElement> Editor::createDefaultParagraphSeparatorElement(Document* document) const
> > +{
> > +    if (defaultParagraphSeparatorIsDiv())
> > +        return HTMLDivElement::create(document);
> > +    return HTMLParagraphElement::create(document);
> 
> We don't want to have this function on Editor. We should just add this to CompositeEditCommand instead.
>

What about the calls in createFragmentFrom{Text,Nodes}? I guess i could go back to the helper function and get to the editor from the document.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list