[Webkit-unassigned] [Bug 59961] Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59961


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129621|review?                     |review-
               Flag|                            |




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2012-02-29 20:43:37 PST ---
(From update of attachment 129621)
View in context: https://bugs.webkit.org/attachment.cgi?id=129621&action=review

> Source/WebCore/editing/Editor.cpp:3028
> +PassRefPtr<HTMLElement> Editor::createDefaultParagraphSeparatorElement(Document* document) const
> +{
> +    if (defaultParagraphSeparatorIsDiv())
> +        return HTMLDivElement::create(document);
> +    return HTMLParagraphElement::create(document);

We don't want to have this function on Editor. We should just add this to CompositeEditCommand instead.

> Source/WebCore/editing/Editor.h:407
> +    bool m_defaultParagraphSeparatorIsDiv; // Should be P otherwise.

Instead of saying that it should be p otherwise, please use enum.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.