[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 09:59:22 PST 2012


Balazs Ankes <bank at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
 Attachment #129058|                            |review?, commit-queue?
               Flag|                            |

--- Comment #2 from Balazs Ankes <bank at inf.u-szeged.hu>  2012-02-27 09:59:21 PST ---
Created an attachment (id=129058)
 --> (https://bugs.webkit.org/attachment.cgi?id=129058&action=review)
patch (work in progress)

I made a png.py file which check the ~/.subversion/config file the auto propset and svn:mime-type=image/png are enabled (based on ttp://trac.webkit.org/wiki/UsingGitWithWebKit Misc. Tips and Tricks) because in git svn there is no propset command. Only auto propset can set the mimetype.
I have some question.
- Is it enough to check the config file?
- I noticed check-webkit-style doesn't support non-text files. I tried to solve the task elegant, but I think I couldn't. What should I do?
- If there is a style error related with pngs I want to add to the global error counter. How can I do this nicely?
Any ideas that should be implement?

(I know I have to write unit tests.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list