[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 11:16:52 PST 2012


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #129058|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #3 from Tony Chang <tony at chromium.org>  2012-02-27 11:16:52 PST ---
(From update of attachment 129058)
View in context: https://bugs.webkit.org/attachment.cgi?id=129058&action=review

I think checking to see if the user's subversion config file is correct is useful, however, that doesn't actually fix this specific bug where certain files might not have the right svn properties set.  I.e., this should probably be a separate bug.

> Tools/Scripts/webkitpy/style/checkers/png.py:25
>  """Supports checking WebKit style in png files."""

This diff is weird.  I don't see png.py in the tree currently.

> Tools/Scripts/webkitpy/style/checkers/png.py:42
> +            for line in open(os.path.expanduser("~") + "/.subversion/config", 'r').readlines():

Does this work with Windows python?  Does this work with Windows svn?

> Tools/Scripts/webkitpy/style/patchreader.py:65
> +                _log.debug("Using class: " + checker.__class__.__name__)

I would remove this log line.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list