[Webkit-unassigned] [Bug 79212] [BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79212


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128375|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Antonio Gomes <tonikitoo at webkit.org>  2012-02-23 20:21:55 PST ---
(From update of attachment 128375)
View in context: https://bugs.webkit.org/attachment.cgi?id=128375&action=review

>>> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:52
>>> +        context->fillRect(FloatRect(-1, -7, 2, 14));
>> 
>> some magic numbers here. Anyway we could improve it?
> 
> We just want to draw a "x" here. Maybe i should add a comment?

please add.

>>> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:70
>>> +    img->setData(buffer.release(), true);
>> 
>> what is true here?
> 
> true == allDataReceived
> bool Image::setData(PassRefPtr<SharedBuffer> data, bool allDataReceived);

lets add a /*allDataReceived*/ comment

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.