[Webkit-unassigned] [Bug 79212] [BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79212





--- Comment #3 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-02-22 19:48:18 PST ---
(In reply to comment #2)
> (From update of attachment 128163 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128163&action=review
> 
> Still some stuff to improve.
> 
> > Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:2
> > + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.
> 
> Needs 2012.

Will add.

> > Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:30
> > +    String iconName(name); // a.k.a. "enable string comparisons with =="
> 
> I dont see a need for this, why not just use strcmp?
> 

Good point.

> > Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:40
> > +        context->fillRect(FloatRect(0, 0, 16, 16), Color::white, ColorSpaceDeviceRGB);
> 
> There may be a variant that flood fills the entire surface, then you dont need to specify the FloatRect.
> 

GraphicsContext does not have functions that flood fills the entire surface, though SkCanvas have such functions.
We can change it something like this:

SkCanvas* canvas = context->platformContext()->canvas();
canvas->drawColor(SK_ColorWHITE);

Both are ok for me, but I prefer not to change it.

> > Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:59
> > +    // FIXME: Have a setting for the resource path
> 
> Is the FIXME still accurate?

I don't think we need to add a public setting for the resource path. And seems no other ports did this.
I will remove the FIXME.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.