[Webkit-unassigned] [Bug 79212] [BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79212


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128163|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-22 04:25:05 PST ---
(From update of attachment 128163)
View in context: https://bugs.webkit.org/attachment.cgi?id=128163&action=review

Still some stuff to improve.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:2
> + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.

Needs 2012.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:30
> +    String iconName(name); // a.k.a. "enable string comparisons with =="

I dont see a need for this, why not just use strcmp?

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:40
> +        context->fillRect(FloatRect(0, 0, 16, 16), Color::white, ColorSpaceDeviceRGB);

There may be a variant that flood fills the entire surface, then you dont need to specify the FloatRect.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:59
> +    // FIXME: Have a setting for the resource path

Is the FIXME still accurate?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.