[Webkit-unassigned] [Bug 53600] [GTK] Add DRT support for modal dialogs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53600





--- Comment #16 from Zan Dobersek <zandobersek at gmail.com>  2012-02-22 01:56:27 PST ---
(From update of attachment 126324)
View in context: https://bugs.webkit.org/attachment.cgi?id=126324&action=review

>>>> Source/WebKit/gtk/webkit/webkitwebview.cpp:2756
>>>> +     *
>>> 
>>> Signal is true_handled, it should include information about the Return value:
>>> 
>>> * Return value: %TRUE to stop handlers from being invoked for the event or                                                                                                              
>>>      * %FALSE to propagate the event furter
>> 
>> I'd like to be more verbose - %TRUE to stop handlers being invoked and run the modal dialog loop, %FALSE to state that the modal dialog should not be run and propagate the event further.
>> 
>> (Not this exact wording, but something similar.)
> 
> Well, this is kind of stantard text we use in every signal that is true_handled.

OK then, the standard text is fine but the documentation should state clearly what will be going on based on the return value of the handler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.