[Webkit-unassigned] [Bug 76181] [GTK] FullScreen signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 06:16:56 PST 2012


--- Comment #20 from Philippe Normand <pnormand at igalia.com>  2012-02-20 06:16:56 PST ---
(In reply to comment #19)
> (From update of attachment 127550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127550&action=review
> > Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:970
> > +    g_signal_emit_by_name(m_webView, "entering-fullscreen", &returnValue);
> The signal seems sensible to me, but I think we should take advantage of the DOM bindings and also provide the element that is being fullscreened.

Embedded in the signal data? Hum I guess that'd be doable.

> > Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:984
> > +    gtk_window_fullscreen(GTK_WINDOW(window));
> I'm not sure about this. I guess it makes sense to fullscreen by default, but I wonder if it may be problematic for non-browser use cases, to do it by default if the page requests. hmm

Well, this whole feature is protected by a web-setting which defaults to FALSE, IIRC.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list