[Webkit-unassigned] [Bug 76181] [GTK] FullScreen signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 06:18:25 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76181





--- Comment #21 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-20 06:18:25 PST ---
(In reply to comment #20)
> > > Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:970
> > > +    g_signal_emit_by_name(m_webView, "entering-fullscreen", &returnValue);
> > 
> > The signal seems sensible to me, but I think we should take advantage of the DOM bindings and also provide the element that is being fullscreened.
> > 
> 
> Embedded in the signal data? Hum I guess that'd be doable.

As a signal parameter, yeah =)

> > I'm not sure about this. I guess it makes sense to fullscreen by default, but I wonder if it may be problematic for non-browser use cases, to do it by default if the page requests. hmm
> 
> Well, this whole feature is protected by a web-setting which defaults to FALSE, IIRC.

OK, +1 from me on this then =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list