[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127553|review?                     |review-
               Flag|                            |




--- Comment #33 from Kent Tamura <tkent at chromium.org>  2012-02-17 16:40:34 PST ---
(From update of attachment 127553)
View in context: https://bugs.webkit.org/attachment.cgi?id=127553&action=review

Please announce this feature to webkit-dev.
http://www.webkit.org/coding/adding-features.html

Does MedieaCaptureChooser set a file name to FileChooerClient?  If so, who removes the file? <input type=file> shows a file name for a captured data?

> Source/WebCore/platform/FileChooser.cpp:72
> +    if (equalIgnoringCase(input->capture(), MediaCaptureNames::camera())) {

input->capture() should be input->fastGetAttribute(captureAttr), and should remove HTMLInputElement::capture().
Anyway, this is a layering violation.

> Source/WebCore/platform/FileChooser.h:74
> +    MediaCaptureType determineCaptureType(HTMLInputElement*);

Layering violation.  We must not use WebCore/html/* classes in WebCore/platform/* files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.