[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #32 from Ben Murdoch <benm at google.com>  2012-02-17 06:28:20 PST ---
> > > Source/WebCore/platform/FileChooser.cpp:73
> > > +        for (Vector<String>::const_iterator iterator = input->acceptMIMETypes().begin(); iterator != input->acceptMIMETypes().end(); ++iterator)
> > 
> > Could this be replaced with something like:
> > if (MIMETypeRegistry::isSupportCaptureType("image/*") && input->acceptMIMETypes().contains("image/*)) ?
> > 
> Could you please check the URL? 
> (http://lists.w3.org/Archives/Public/public-device-apis/2011Apr/0013.html)
> I'd like to implement a good solution to meet the editor's idea.
> Could you please give me your idea?

Oh, I see. It covers the case that the accept type was image/svg mentioned in that email.


> > > Source/WebCore/platform/FileChooser.h:44
> > > +#endif
> > 
> > Maybe merge these two #ifdef blocks?
> > 
> > > Source/WebCore/platform/FileChooser.h:51
> > > +    Microphone,
> > 
> > These should probably be in alphabetical order.
> >
> Do you mean that named types in enum should be sorted? I observed that there are many enum types that they don't meet the coding style. 
> Could you please clarify the coding style?

That's what I meant, but you're right, the style guide doesn't enforce it. IMO I think it looks neater, but whichever you prefer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.