[Webkit-unassigned] [Bug 78893] [GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78893


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127578|review?                     |review+
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-17 06:07:55 PST ---
(From update of attachment 127578)
View in context: https://bugs.webkit.org/attachment.cgi?id=127578&action=review

Looks good to me; also having an enum allows us to expand this API more easily, though I think it'll probably not need too much change in the future after it settles =)

> Source/WebKit2/ChangeLog:18
> +        (webkitPrintOperationRunDialogWin32): Dittoo.

s/oo/o/

> Source/WebKit2/ChangeLog:20
> +        (webkitPrintOperationRunDialogForFrame): Do ot emit finished if

s/ot/not/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.