[Webkit-unassigned] [Bug 78893] [GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 05:53:37 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78893


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127578|                            |review?
               Flag|                            |




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-17 05:53:37 PST ---
Created an attachment (id=127578)
 --> (https://bugs.webkit.org/attachment.cgi?id=127578&action=review)
Patch

It's not emitted anynmore when the print dialog has been cancelled. Since it's not possible to know whether the print dialog was cancelled or not, the enum WebKitPrintOperationResponse has been added, with Print and Cancel values, and it's used as return value of webkit_print_operation_run_dialog(). I've used an enum instead of a boolean just in case we add WEBKIT_PRINT_OPERATION_RESPONSE_PREVIEW in the future

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list