[Webkit-unassigned] [Bug 76948] min-width is not implemented on <table> for table-layout: fixed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76948





--- Comment #9 from Antaryami Pandia <antaryami.pandia at motorola.com>  2012-02-14 21:54:40 PST ---
(In reply to comment #8)
Thanks for the information. I am just trying to understand the code changes.

> If I'm understanding your question correctly, the code in RenderTable::computeLogicalWidth is necessary to handle percent widths and percent min-widths. Specifically, the following line in RenderTable::convertStyleLogicalWidthToComputedWidth resolves a percent value based on the container size (or just returns the fixed value):
> 
>     return styleLogicalWidth.calcMinValue(availableWidth) + borders;
> 
> AutoTableLayout::computePreferredLogicalWidths does not look at percent values, but it does look at fixed values.

Sorry, I think I have mis-represented my query.The code in "RenderTable::computeLogicalWidth" is necessary.I was just asking about the below code:-

Method :- "RenderTable::computeLogicalWidth"
// Ensure we aren't smaller than our min-width style.
Length styleMinLogicalWidth = style()->logicalMinWidth();
if (styleMinLogicalWidth.isSpecified() && styleMinLogicalWidth.isPositive())
     setLogicalWidth(max(logicalWidth(), ConvertStyleLogicalWidthToComputedWidth(styleMinLogicalWidth, availableLogicalWidth)));



> > And if the code in "RenderTable::computeLogicalWidth" does not have any specific use case can we remove this.
> 
> Which lines are you talking about specifically?

Same code as mentioned above. I was just thinking if this is not doing any specific job, then can we remove it place code similar as "AutotableLayout" (which sets the min-width ) in fixedtablelayout.cpp. 

> > Here I am assuming that the purpose of the code in RenderTable.cpp is not to fix the "table-layout: fixed" case. Please correct me if I am wrong.
> 
> You're right. It's not intended to fix the table-layout: fixed case.

Thanks a lot for your time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.