[Webkit-unassigned] [Bug 76948] min-width is not implemented on <table> for table-layout: fixed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76948





--- Comment #8 from Max Vujovic <mvujovic at adobe.com>  2012-02-14 16:50:52 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> Yes the code AutoTableLayout::computePreferredLogicalWidths is required. Actually what I was saying was "AutoTableLayout::computePreferredLogicalWidths" already sets the minwidth and maxwidth, so what's purpose of code added in "RenderTable::computeLogicalWidth". Does this code solves any specific issue?

If I'm understanding your question correctly, the code in RenderTable::computeLogicalWidth is necessary to handle percent widths and percent min-widths. Specifically, the following line in RenderTable::convertStyleLogicalWidthToComputedWidth resolves a percent value based on the container size (or just returns the fixed value):

    return styleLogicalWidth.calcMinValue(availableWidth) + borders;

AutoTableLayout::computePreferredLogicalWidths does not look at percent values, but it does look at fixed values.

> And if the code in "RenderTable::computeLogicalWidth" does not have any specific use case can we remove this.

Which lines are you talking about specifically?

> Here I am assuming that the purpose of the code in RenderTable.cpp is not to fix the "table-layout: fixed" case. Please correct me if I am wrong.

You're right. It's not intended to fix the table-layout: fixed case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.